From: J. Ali Harlow <ali@juiblex.co.uk>
Date: Wed, 1 Feb 2012 12:47:50 +0000 (+0000)
Subject: Fix bug causing writes to an unallocated buffer
X-Git-Tag: 0.5.2~1
X-Git-Url: http://project.juiblex.co.uk/git/?a=commitdiff_plain;h=d5ebf75f18cba8cd6e90f37afb7c99fba544d3ea;p=razor2.git%2F.git

Fix bug causing writes to an unallocated buffer
---

diff --git a/librazor/razor.c b/librazor/razor.c
index 3056338..d7684b4 100644
--- a/librazor/razor.c
+++ b/librazor/razor.c
@@ -633,7 +633,7 @@ razor_package_remove(struct razor_set *prev, struct razor_set *next,
 	struct razor_file_iterator *fi;
 	struct razor_package_iterator *pi;
 	struct razor_package *p;
-	char *buffer;
+	char *buffer, buf[32];
 	const char *name, *program, *script;
 	int i, count;
 	struct environment env;
@@ -647,8 +647,8 @@ razor_package_remove(struct razor_set *prev, struct razor_set *next,
 		for (i = 0; link; i++) {
 			prefix = (const char *)prev->string_pool.data +
 				 link->data;
-			sprintf(buffer, "RPM_INSTALL_PREFIX%d", i);
-			environment_add_variable(&env, buffer, prefix);
+			sprintf(buf, "RPM_INSTALL_PREFIX%d", i);
+			environment_add_variable(&env, buf, prefix);
 			link = list_next(link);
 		}
 		environment_set(&env);