librazor/transaction.c
author J. Ali Harlow <ali@juiblex.co.uk>
Tue Mar 27 21:29:53 2012 +0100 (2012-03-27)
changeset 434 2c25dc58c6d2
parent 403 e63951c1d0f8
child 438 fab0b8a61dcb
permissions -rw-r--r--
Start 0.5.6
krh@248
     1
/*
krh@248
     2
 * Copyright (C) 2008  Kristian Høgsberg <krh@redhat.com>
krh@248
     3
 * Copyright (C) 2008  Red Hat, Inc
ali@432
     4
 * Copyright (C) 2009, 2011, 2012  J. Ali Harlow <ali@juiblex.co.uk>
krh@248
     5
 *
krh@248
     6
 * This program is free software; you can redistribute it and/or modify
krh@248
     7
 * it under the terms of the GNU General Public License as published by
krh@248
     8
 * the Free Software Foundation; either version 2 of the License, or
krh@248
     9
 * (at your option) any later version.
krh@248
    10
 *
krh@248
    11
 * This program is distributed in the hope that it will be useful,
krh@248
    12
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
krh@248
    13
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
krh@248
    14
 * GNU General Public License for more details.
krh@248
    15
 *
krh@248
    16
 * You should have received a copy of the GNU General Public License along
krh@248
    17
 * with this program; if not, write to the Free Software Foundation, Inc.,
krh@248
    18
 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
krh@248
    19
 */
krh@248
    20
krh@248
    21
#define _GNU_SOURCE
krh@248
    22
krh@248
    23
#include <stdlib.h>
krh@248
    24
#include <stddef.h>
krh@248
    25
#include <stdint.h>
krh@248
    26
#include <stdio.h>
krh@248
    27
#include <string.h>
krh@248
    28
#include <sys/types.h>
krh@248
    29
#include <sys/stat.h>
krh@248
    30
#include <unistd.h>
krh@248
    31
#include <fcntl.h>
krh@248
    32
#include <errno.h>
krh@248
    33
#include <ctype.h>
richard@301
    34
#include <assert.h>
krh@248
    35
krh@248
    36
#include "razor-internal.h"
krh@248
    37
#include "razor.h"
krh@248
    38
krh@248
    39
static int
krh@248
    40
provider_satisfies_requirement(struct razor_property *provider,
krh@248
    41
			       const char *provider_strings,
krh@248
    42
			       uint32_t flags,
krh@248
    43
			       const char *required)
krh@248
    44
{
krh@248
    45
	int cmp, len;
krh@248
    46
	const char *provided = &provider_strings[provider->version];
krh@248
    47
krh@248
    48
	if (!*required)
krh@248
    49
		return 1;
krh@248
    50
	if (!*provided) {
krh@248
    51
		if (flags & RAZOR_PROPERTY_LESS)
krh@248
    52
			return 0;
krh@248
    53
		else
krh@248
    54
			return 1;
krh@248
    55
	}
krh@248
    56
krh@248
    57
	cmp = razor_versioncmp(provided, required);
krh@248
    58
krh@248
    59
	switch (flags & RAZOR_PROPERTY_RELATION_MASK) {
krh@248
    60
	case RAZOR_PROPERTY_LESS:
krh@248
    61
		return cmp < 0;
krh@248
    62
krh@248
    63
	case RAZOR_PROPERTY_LESS | RAZOR_PROPERTY_EQUAL:
krh@248
    64
		if (cmp <= 0)
krh@248
    65
			return 1;
krh@248
    66
		/* fall through: FIXME, make sure this is correct */
krh@248
    67
krh@248
    68
	case RAZOR_PROPERTY_EQUAL:
krh@248
    69
		if (cmp == 0)
krh@248
    70
			return 1;
krh@248
    71
krh@248
    72
		/* "foo == 1.1" is satisfied by "foo 1.1-2" */
krh@248
    73
		len = strlen(required);
krh@248
    74
		if (!strncmp(required, provided, len) && provided[len] == '-')
krh@248
    75
			return 1;
krh@248
    76
		return 0;
krh@248
    77
krh@248
    78
	case RAZOR_PROPERTY_GREATER | RAZOR_PROPERTY_EQUAL:
krh@248
    79
		return cmp >= 0;
krh@248
    80
krh@248
    81
	case RAZOR_PROPERTY_GREATER:
krh@248
    82
		return cmp > 0;
krh@248
    83
	}
krh@248
    84
krh@248
    85
	/* shouldn't happen */
krh@248
    86
	return 0;
krh@248
    87
}
krh@248
    88
krh@248
    89
#define TRANS_PACKAGE_PRESENT		1
krh@248
    90
#define TRANS_PACKAGE_UPDATE		2
krh@248
    91
#define TRANS_PROPERTY_SATISFIED	0x80000000
krh@248
    92
krh@248
    93
struct transaction_set {
krh@248
    94
	struct razor_set *set;
krh@248
    95
	uint32_t *packages;
krh@248
    96
	uint32_t *properties;
krh@248
    97
};
krh@248
    98
krh@248
    99
struct razor_transaction {
krh@248
   100
	int package_count, errors;
krh@248
   101
	struct transaction_set system, upstream;
krh@248
   102
	int changes;
ali@369
   103
	struct razor_merger *merger;
krh@248
   104
};
krh@248
   105
krh@248
   106
static void
krh@248
   107
transaction_set_init(struct transaction_set *ts, struct razor_set *set)
krh@248
   108
{
krh@248
   109
	int count;
krh@248
   110
ali@403
   111
	ts->set = razor_set_ref(set);
krh@248
   112
	count = set->packages.size / sizeof (struct razor_package);
krh@248
   113
	ts->packages = zalloc(count * sizeof *ts->packages);
krh@248
   114
	count = set->properties.size / sizeof (struct razor_property);
krh@248
   115
	ts->properties = zalloc(count * sizeof *ts->properties);
krh@248
   116
}
krh@248
   117
krh@248
   118
static void
krh@248
   119
transaction_set_release(struct transaction_set *ts)
krh@248
   120
{
ali@403
   121
	razor_set_unref(ts->set);
krh@248
   122
	free(ts->packages);
krh@248
   123
	free(ts->properties);
krh@248
   124
}
krh@248
   125
krh@248
   126
static void
krh@248
   127
transaction_set_install_package(struct transaction_set *ts,
krh@248
   128
				struct razor_package *package)
krh@248
   129
{
krh@248
   130
	struct razor_package *pkgs;
krh@248
   131
	struct list *prop;
krh@248
   132
	int i;
krh@248
   133
krh@248
   134
	pkgs = ts->set->packages.data;
krh@248
   135
	i = package - pkgs;
ali@432
   136
	if (ts->packages[i] & TRANS_PACKAGE_PRESENT)
krh@248
   137
		return;
krh@248
   138
ali@432
   139
	ts->packages[i] |= TRANS_PACKAGE_PRESENT;
krh@248
   140
krh@248
   141
	prop = list_first(&package->properties, &ts->set->property_pool);
krh@248
   142
	while (prop) {
krh@248
   143
		ts->properties[prop->data]++;
krh@248
   144
		prop = list_next(prop);
krh@248
   145
	}
krh@248
   146
}
krh@248
   147
krh@248
   148
static void
krh@248
   149
transaction_set_remove_package(struct transaction_set *ts,
krh@248
   150
			       struct razor_package *package)
krh@248
   151
{
krh@248
   152
	struct razor_package *pkgs;
krh@248
   153
	struct list *prop;
krh@248
   154
	int i;
krh@248
   155
krh@248
   156
	pkgs = ts->set->packages.data;
krh@248
   157
	i = package - pkgs;
ali@432
   158
	if (!(ts->packages[i] & TRANS_PACKAGE_PRESENT))
krh@248
   159
		return;
krh@248
   160
ali@432
   161
	ts->packages[i] &= ~TRANS_PACKAGE_PRESENT;
krh@248
   162
krh@248
   163
	prop = list_first(&package->properties, &ts->set->property_pool);
krh@248
   164
	while (prop) {
krh@248
   165
		ts->properties[prop->data]--;
krh@248
   166
		prop = list_next(prop);
krh@248
   167
	}
krh@248
   168
}
krh@248
   169
krh@269
   170
RAZOR_EXPORT struct razor_transaction *
krh@248
   171
razor_transaction_create(struct razor_set *system, struct razor_set *upstream)
krh@248
   172
{
krh@248
   173
	struct razor_transaction *trans;
krh@248
   174
	struct razor_package *p, *spkgs, *pend;
krh@248
   175
krh@248
   176
	trans = zalloc(sizeof *trans);
krh@248
   177
	transaction_set_init(&trans->system, system);
krh@248
   178
	transaction_set_init(&trans->upstream, upstream);
krh@248
   179
krh@248
   180
	spkgs = trans->system.set->packages.data;
krh@248
   181
	pend = trans->system.set->packages.data +
krh@248
   182
		trans->system.set->packages.size;
krh@248
   183
	for (p = spkgs; p < pend; p++)
krh@248
   184
		transaction_set_install_package(&trans->system, p);
krh@248
   185
krh@248
   186
	return trans;
krh@248
   187
}
krh@248
   188
krh@269
   189
RAZOR_EXPORT void
krh@248
   190
razor_transaction_install_package(struct razor_transaction *trans,
krh@248
   191
				  struct razor_package *package)
krh@248
   192
{
richard@301
   193
	assert (trans != NULL);
richard@301
   194
	assert (package != NULL);
richard@301
   195
krh@248
   196
	transaction_set_install_package(&trans->upstream, package);
krh@248
   197
	trans->changes++;
krh@248
   198
}
krh@248
   199
krh@269
   200
RAZOR_EXPORT void
krh@248
   201
razor_transaction_remove_package(struct razor_transaction *trans,
krh@248
   202
				 struct razor_package *package)
krh@248
   203
{
richard@301
   204
	assert (trans != NULL);
richard@301
   205
	assert (package != NULL);
richard@301
   206
krh@248
   207
	transaction_set_remove_package(&trans->system, package);
krh@248
   208
	trans->changes++;
krh@248
   209
}
krh@248
   210
krh@269
   211
RAZOR_EXPORT void
krh@248
   212
razor_transaction_update_package(struct razor_transaction *trans,
krh@248
   213
				  struct razor_package *package)
krh@248
   214
{
krh@248
   215
	struct razor_package *spkgs, *upkgs, *end;
krh@248
   216
richard@301
   217
	assert (trans != NULL);
richard@301
   218
	assert (package != NULL);
richard@301
   219
krh@248
   220
	spkgs = trans->system.set->packages.data;
krh@248
   221
	upkgs = trans->upstream.set->packages.data;
krh@248
   222
	end = trans->system.set->packages.data +
krh@248
   223
		trans->system.set->packages.size;
krh@248
   224
	if (spkgs <= package && package < end)
krh@248
   225
		trans->system.packages[package - spkgs] |= TRANS_PACKAGE_UPDATE;
krh@248
   226
	else
krh@248
   227
		trans->upstream.packages[package - upkgs] |= TRANS_PACKAGE_UPDATE;
krh@248
   228
}
krh@248
   229
krh@248
   230
struct prop_iter {
krh@248
   231
	struct razor_property *p, *start, *end;
krh@248
   232
	const char *pool;
krh@248
   233
	uint32_t *present;
krh@248
   234
};
krh@248
   235
krh@248
   236
static void
krh@248
   237
prop_iter_init(struct prop_iter *pi, struct transaction_set *ts)
krh@248
   238
{
krh@248
   239
	pi->p = ts->set->properties.data;
krh@248
   240
	pi->start = ts->set->properties.data;
krh@248
   241
	pi->end = ts->set->properties.data + ts->set->properties.size;
krh@248
   242
	pi->pool = ts->set->string_pool.data;
krh@248
   243
	pi->present = ts->properties;
krh@248
   244
}
krh@248
   245
krh@248
   246
static int
krh@248
   247
prop_iter_next(struct prop_iter *pi, uint32_t flags, struct razor_property **p)
krh@248
   248
{
krh@248
   249
	while (pi->p < pi->end) {
krh@248
   250
		if ((pi->present[pi->p - pi->start] & ~TRANS_PROPERTY_SATISFIED) &&
krh@248
   251
		    (pi->p->flags & RAZOR_PROPERTY_TYPE_MASK) == flags) {
krh@248
   252
			*p = pi->p++;
krh@248
   253
			return 1;
krh@248
   254
		}
krh@248
   255
		pi->p++;
krh@248
   256
	}
krh@248
   257
krh@248
   258
	return 0;
krh@248
   259
}
krh@248
   260
krh@248
   261
static struct razor_property *
krh@248
   262
prop_iter_seek_to(struct prop_iter *pi,
krh@248
   263
		  uint32_t flags, const char *match)
krh@248
   264
{
krh@248
   265
	uint32_t name;
krh@248
   266
krh@248
   267
	while (pi->p < pi->end && strcmp(&pi->pool[pi->p->name], match) < 0)
krh@248
   268
		pi->p++;
krh@248
   269
krh@248
   270
	if (pi->p == pi->end || strcmp(&pi->pool[pi->p->name], match) > 0)
krh@248
   271
		return NULL;
krh@248
   272
krh@248
   273
	name = pi->p->name;
krh@248
   274
	while (pi->p < pi->end &&
krh@248
   275
	       pi->p->name == name &&
krh@248
   276
	       (pi->p->flags & RAZOR_PROPERTY_TYPE_MASK) != flags)
krh@248
   277
		pi->p++;
krh@248
   278
krh@248
   279
	if (pi->p == pi->end || pi->p->name != name)
krh@248
   280
		return NULL;
krh@248
   281
krh@248
   282
	return pi->p;
krh@248
   283
}
krh@248
   284
krh@248
   285
/* Remove packages from set that provide any of the matching (same
krh@248
   286
 * name and type) providers from ppi onwards that match the
krh@248
   287
 * requirement that rpi points to. */
krh@248
   288
static void
krh@248
   289
remove_matching_providers(struct razor_transaction *trans,
krh@248
   290
			  struct prop_iter *ppi,
krh@248
   291
			  uint32_t flags,
krh@248
   292
			  const char *version)
krh@248
   293
{
krh@248
   294
	struct razor_property *p;
krh@248
   295
	struct razor_package *pkg, *pkgs;
krh@248
   296
	struct razor_package_iterator pkg_iter;
krh@248
   297
	struct razor_set *set;
richard@302
   298
	const char *n, *v;
krh@248
   299
	uint32_t type;
krh@248
   300
krh@248
   301
	if (ppi->present == trans->system.properties)
krh@248
   302
		set = trans->system.set;
krh@248
   303
	else
krh@248
   304
		set = trans->upstream.set;
krh@248
   305
krh@248
   306
	pkgs = (struct razor_package *) set->packages.data;
krh@248
   307
	type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
krh@248
   308
	for (p = ppi->p;
krh@248
   309
	     p < ppi->end &&
krh@248
   310
	     p->name == ppi->p->name &&
krh@248
   311
	     (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type;
krh@248
   312
	     p++) {
krh@248
   313
		if (!ppi->present[p - ppi->start])
krh@248
   314
			continue;
krh@248
   315
		if (!provider_satisfies_requirement(p, ppi->pool,
krh@248
   316
						    flags, version))
krh@248
   317
			continue;
krh@248
   318
krh@248
   319
		razor_package_iterator_init_for_property(&pkg_iter, set, p);
richard@302
   320
		while (razor_package_iterator_next(&pkg_iter, &pkg,
richard@302
   321
						   RAZOR_DETAIL_NAME, &n,
richard@307
   322
						   RAZOR_DETAIL_VERSION, &v,
richard@307
   323
						   RAZOR_DETAIL_LAST)) {
ali@403
   324
#if 0
krh@248
   325
			fprintf(stderr, "removing %s-%s\n", n, v);
ali@403
   326
#endif
krh@248
   327
			razor_transaction_remove_package(trans, pkg);
krh@248
   328
		}
krh@248
   329
	}
krh@248
   330
}
krh@248
   331
krh@248
   332
static void
krh@248
   333
flag_matching_providers(struct razor_transaction *trans,
krh@248
   334
			struct prop_iter *ppi,
krh@248
   335
			struct razor_property *r,
krh@248
   336
			struct prop_iter *rpi,
krh@248
   337
			unsigned int flag)
krh@248
   338
{
krh@248
   339
	struct razor_property *p;
krh@248
   340
	struct razor_package *pkg, *pkgs;
krh@248
   341
	struct razor_package_iterator pkg_iter;
krh@248
   342
	struct razor_set *set;
richard@302
   343
	const char *name, *version;
krh@248
   344
	uint32_t *flags, type;
krh@248
   345
krh@248
   346
	if (ppi->present == trans->system.properties) {
krh@248
   347
		set = trans->system.set;
krh@248
   348
		flags = trans->system.packages;
krh@248
   349
	} else {
krh@248
   350
		set = trans->upstream.set;
krh@248
   351
		flags = trans->upstream.packages;
krh@248
   352
	}
krh@248
   353
krh@248
   354
	pkgs = (struct razor_package *) set->packages.data;
krh@248
   355
	type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
krh@248
   356
	for (p = ppi->p;
krh@248
   357
	     p < ppi->end &&
krh@248
   358
		     p->name == ppi->p->name &&
krh@248
   359
		     (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type;
krh@248
   360
	     p++) {
krh@248
   361
		if (!ppi->present[p - ppi->start])
krh@248
   362
			continue;
krh@248
   363
		if (!provider_satisfies_requirement(p, ppi->pool,
krh@248
   364
						    r->flags,
krh@248
   365
						    &rpi->pool[r->version]))
krh@248
   366
			continue;
krh@248
   367
krh@248
   368
		razor_package_iterator_init_for_property(&pkg_iter, set, p);
krh@248
   369
		while (razor_package_iterator_next(&pkg_iter, &pkg,
richard@302
   370
						   RAZOR_DETAIL_NAME, &name,
richard@307
   371
						   RAZOR_DETAIL_VERSION, &version,
richard@307
   372
						   RAZOR_DETAIL_LAST)) {
krh@248
   373
ali@403
   374
#if 0
krh@248
   375
			fprintf(stderr, "flagging %s-%s for providing %s matching %s %s\n",
krh@248
   376
				name, version,
krh@248
   377
				ppi->pool + p->name,
krh@248
   378
				rpi->pool + r->name,
krh@248
   379
				rpi->pool + r->version);
ali@403
   380
#endif
krh@248
   381
			flags[pkg - pkgs] |= flag;
krh@248
   382
		}
krh@248
   383
	}
krh@248
   384
}
krh@248
   385
krh@248
   386
static struct razor_package *
krh@248
   387
pick_matching_provider(struct razor_set *set,
krh@248
   388
		       struct prop_iter *ppi,
krh@248
   389
		       uint32_t flags,
krh@248
   390
		       const char *version)
krh@248
   391
{
krh@248
   392
	struct razor_property *p;
krh@248
   393
	struct razor_package *pkgs;
krh@248
   394
	struct list *i;
krh@248
   395
	uint32_t type;
krh@248
   396
krh@248
   397
	/* This is where we decide which pkgs to pull in to satisfy a
krh@248
   398
	 * requirement.  There may be several different providers
krh@248
   399
	 * (different versions) and each version of a provider may
krh@248
   400
	 * come from a number of packages.  We pick the first package
krh@248
   401
	 * from the first provider that matches. */
krh@248
   402
krh@248
   403
	pkgs = set->packages.data;
krh@248
   404
	type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
krh@248
   405
	for (p = ppi->p;
krh@248
   406
	     p < ppi->end &&
krh@248
   407
		     p->name == ppi->p->name &&
krh@248
   408
		     (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type &&
krh@248
   409
		     ppi->present[p - ppi->start] == 0;
krh@248
   410
	     p++) {
krh@248
   411
		if (!provider_satisfies_requirement(p, ppi->pool,
krh@248
   412
						    flags, version))
krh@248
   413
			continue;
krh@248
   414
krh@248
   415
		i = list_first(&p->packages, &set->package_pool);
krh@248
   416
krh@248
   417
		return &pkgs[i->data];
krh@248
   418
	}
krh@248
   419
krh@248
   420
	return NULL;
krh@248
   421
}
krh@248
   422
krh@248
   423
static void
krh@248
   424
remove_obsoleted_packages(struct razor_transaction *trans)
krh@248
   425
{
krh@248
   426
	struct razor_property *up;
krh@248
   427
	struct razor_package *spkgs;
krh@248
   428
	struct prop_iter spi, upi;
krh@248
   429
krh@248
   430
	spkgs = trans->system.set->packages.data;
krh@248
   431
	prop_iter_init(&spi, &trans->system);
krh@248
   432
	prop_iter_init(&upi, &trans->upstream);
krh@248
   433
krh@248
   434
	while (prop_iter_next(&upi, RAZOR_PROPERTY_OBSOLETES, &up)) {
krh@248
   435
		if (!prop_iter_seek_to(&spi, RAZOR_PROPERTY_PROVIDES,
krh@248
   436
				       &upi.pool[up->name]))
krh@248
   437
			continue;
krh@248
   438
		remove_matching_providers(trans, &spi, up->flags,
krh@248
   439
					  &upi.pool[up->version]);
krh@248
   440
	}
krh@248
   441
}
krh@248
   442
krh@248
   443
static int
krh@248
   444
any_provider_satisfies_requirement(struct prop_iter *ppi,
krh@248
   445
				   uint32_t flags,
krh@248
   446
				   const char *version)
krh@248
   447
{
krh@248
   448
	struct razor_property *p;
krh@248
   449
	uint32_t type;
krh@248
   450
krh@248
   451
	type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
krh@248
   452
	for (p = ppi->p;
krh@248
   453
	     p < ppi->end &&
krh@248
   454
		     p->name == ppi->p->name &&
krh@248
   455
		     (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type;
krh@248
   456
	     p++) {
krh@248
   457
		if (ppi->present[p - ppi->start] > 0 &&
krh@248
   458
		    provider_satisfies_requirement(p, ppi->pool,
krh@248
   459
						   flags, version))
krh@248
   460
			return 1;
krh@248
   461
	}
krh@248
   462
krh@248
   463
	return 0;
krh@248
   464
}
krh@248
   465
krh@248
   466
static void
krh@248
   467
clear_requires_flags(struct transaction_set *ts)
krh@248
   468
{
krh@248
   469
	struct razor_property *p;
krh@248
   470
	const char *pool;
krh@248
   471
	int i, count;
ali@368
   472
	char *sub;
krh@248
   473
krh@248
   474
	count = ts->set->properties.size / sizeof *p;
krh@248
   475
	p = ts->set->properties.data;
krh@248
   476
	pool = ts->set->string_pool.data;
krh@248
   477
	for (i = 0; i < count; i++) {
krh@248
   478
		ts->properties[i] &= ~TRANS_PROPERTY_SATISFIED;
ali@368
   479
		sub = strchr(&pool[p[i].name], '(');
ali@368
   480
		if (sub && sub[strlen(sub) - 1] == ')') {
ali@368
   481
			sub = strdup(sub + 1);
ali@368
   482
			sub[strlen(sub) - 1] = '\0';
ali@368
   483
			if (strncmp(&pool[p[i].name], "rpmlib(", 7) == 0)
ali@368
   484
				ts->properties[i] |= TRANS_PROPERTY_SATISFIED;
ali@368
   485
			if (strncmp(&pool[p[i].name], "lua(", 4) == 0 &&
ali@368
   486
			    razor_get_lua_loader(sub) &&
ali@368
   487
			    p[i].flags & RAZOR_PROPERTY_SCRIPT_MASK)
ali@368
   488
				ts->properties[i] |= TRANS_PROPERTY_SATISFIED;
ali@368
   489
			free(sub);
ali@368
   490
		}
krh@248
   491
	}
krh@248
   492
}
krh@248
   493
krh@248
   494
static void
krh@248
   495
mark_satisfied_requires(struct razor_transaction *trans,
krh@248
   496
			struct transaction_set *rts,
krh@248
   497
			struct transaction_set *pts)
krh@248
   498
{
krh@248
   499
	struct prop_iter rpi, ppi;
krh@248
   500
	struct razor_property *rp;
krh@248
   501
krh@248
   502
	prop_iter_init(&rpi, rts);
krh@248
   503
	prop_iter_init(&ppi, pts);
krh@248
   504
krh@248
   505
	while (prop_iter_next(&rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
krh@248
   506
		if (!prop_iter_seek_to(&ppi, RAZOR_PROPERTY_PROVIDES,
krh@248
   507
				       &rpi.pool[rp->name]))
krh@248
   508
			continue;
krh@248
   509
krh@248
   510
		if (any_provider_satisfies_requirement(&ppi, rp->flags,
krh@248
   511
						       &rpi.pool[rp->version]))
krh@248
   512
			rpi.present[rp - rpi.start] |= TRANS_PROPERTY_SATISFIED;
krh@248
   513
	}
krh@248
   514
}
krh@248
   515
krh@248
   516
static void
krh@248
   517
mark_all_satisfied_requires(struct razor_transaction *trans)
krh@248
   518
{
krh@248
   519
	clear_requires_flags(&trans->system);
krh@248
   520
	clear_requires_flags(&trans->upstream);
krh@248
   521
	mark_satisfied_requires(trans, &trans->system, &trans->system);
krh@248
   522
	mark_satisfied_requires(trans, &trans->system, &trans->upstream);
krh@248
   523
	mark_satisfied_requires(trans, &trans->upstream, &trans->system);
krh@248
   524
	mark_satisfied_requires(trans, &trans->upstream, &trans->upstream);
krh@248
   525
}
krh@248
   526
krh@248
   527
static void
krh@248
   528
update_unsatisfied_packages(struct razor_transaction *trans)
krh@248
   529
{
krh@248
   530
	struct razor_package *spkgs, *pkg;
krh@248
   531
	struct razor_property *sp;
krh@248
   532
	struct prop_iter spi;
krh@248
   533
	struct razor_package_iterator pkg_iter;
richard@302
   534
	const char *name;
krh@248
   535
krh@248
   536
	spkgs = trans->system.set->packages.data;
krh@248
   537
	prop_iter_init(&spi, &trans->system);
krh@248
   538
krh@248
   539
	while (prop_iter_next(&spi, RAZOR_PROPERTY_REQUIRES, &sp)) {
krh@248
   540
		if (spi.present[sp - spi.start] & TRANS_PROPERTY_SATISFIED)
krh@248
   541
			continue;
krh@248
   542
krh@248
   543
		razor_package_iterator_init_for_property(&pkg_iter,
krh@248
   544
							 trans->system.set,
krh@248
   545
							 sp);
krh@248
   546
		while (razor_package_iterator_next(&pkg_iter, &pkg,
richard@307
   547
						   RAZOR_DETAIL_NAME, &name,
richard@307
   548
						   RAZOR_DETAIL_LAST)) {
ali@432
   549
			if (!(trans->system.packages[pkg - spkgs] & TRANS_PACKAGE_PRESENT))
ali@432
   550
				continue;
ali@432
   551
ali@403
   552
#if 0
krh@248
   553
			fprintf(stderr, "updating %s because %s %s %s "
krh@248
   554
				"isn't satisfied\n",
krh@248
   555
				name, spi.pool + sp->name,
krh@248
   556
				razor_property_relation_to_string(sp),
krh@248
   557
				spi.pool + sp->version);
ali@403
   558
#endif
krh@248
   559
			trans->system.packages[pkg - spkgs] |=
krh@248
   560
				TRANS_PACKAGE_UPDATE;
krh@248
   561
		}
krh@248
   562
	}
krh@248
   563
}
krh@248
   564
krh@269
   565
RAZOR_EXPORT void
krh@248
   566
razor_transaction_update_all(struct razor_transaction *trans)
krh@248
   567
{
krh@248
   568
	struct razor_package *p;
krh@248
   569
	int i, count;
krh@248
   570
richard@301
   571
	assert (trans != NULL);
richard@301
   572
krh@248
   573
	count = trans->system.set->packages.size / sizeof *p;
krh@248
   574
	for (i = 0; i < count; i++)
krh@248
   575
		trans->system.packages[i] |= TRANS_PACKAGE_UPDATE;
krh@248
   576
}
krh@248
   577
krh@248
   578
static void
krh@248
   579
update_conflicted_packages(struct razor_transaction *trans)
krh@248
   580
{
krh@248
   581
	struct razor_package *pkg, *spkgs;
krh@248
   582
	struct razor_property *up, *sp;
krh@248
   583
	struct prop_iter spi, upi;
krh@248
   584
	struct razor_package_iterator pkg_iter;
richard@302
   585
	const char *name, *version;
krh@248
   586
krh@248
   587
	spkgs = trans->system.set->packages.data;
krh@248
   588
	prop_iter_init(&spi, &trans->system);
krh@248
   589
	prop_iter_init(&upi, &trans->upstream);
krh@248
   590
krh@248
   591
	while (prop_iter_next(&spi, RAZOR_PROPERTY_CONFLICTS, &sp)) {
krh@248
   592
		if (!prop_iter_seek_to(&upi, RAZOR_PROPERTY_PROVIDES,
krh@248
   593
				       &spi.pool[sp->name]))
krh@248
   594
			continue;
krh@248
   595
krh@248
   596
		if (!any_provider_satisfies_requirement(&upi, sp->flags,
krh@248
   597
							&spi.pool[sp->version]))
krh@248
   598
			continue;
krh@248
   599
krh@248
   600
		razor_package_iterator_init_for_property(&pkg_iter,
krh@248
   601
							 trans->system.set,
krh@248
   602
							 sp);
krh@248
   603
		while (razor_package_iterator_next(&pkg_iter, &pkg,
richard@302
   604
						   RAZOR_DETAIL_NAME, &name,
richard@307
   605
						   RAZOR_DETAIL_VERSION, &version,
richard@307
   606
						   RAZOR_DETAIL_LAST)) {
ali@403
   607
#if 0
jbowes@286
   608
			fprintf(stderr, "updating %s %s because it "
jbowes@286
   609
				"conflicts with %s\n",
krh@248
   610
				name, version, spi.pool + sp->name);
ali@403
   611
#endif
krh@248
   612
			trans->system.packages[pkg - spkgs] |=
krh@248
   613
				TRANS_PACKAGE_UPDATE;
krh@248
   614
		}
krh@248
   615
	}
krh@248
   616
krh@248
   617
	prop_iter_init(&spi, &trans->system);
krh@248
   618
	prop_iter_init(&upi, &trans->upstream);
krh@248
   619
krh@248
   620
	while (prop_iter_next(&upi, RAZOR_PROPERTY_CONFLICTS, &up)) {
krh@248
   621
		sp = prop_iter_seek_to(&spi, RAZOR_PROPERTY_PROVIDES,
krh@248
   622
				       &upi.pool[upi.p->name]);
krh@248
   623
krh@248
   624
		if (sp)
krh@248
   625
			flag_matching_providers(trans, &spi, up, &upi,
krh@248
   626
						TRANS_PACKAGE_UPDATE);
krh@248
   627
	}
krh@248
   628
}
krh@248
   629
krh@248
   630
static void
krh@248
   631
pull_in_requirements(struct razor_transaction *trans,
krh@248
   632
		     struct prop_iter *rpi, struct prop_iter *ppi)
krh@248
   633
{
krh@248
   634
	struct razor_property *rp, *pp;
krh@248
   635
	struct razor_package *pkg, *upkgs;
krh@248
   636
krh@248
   637
	upkgs = trans->upstream.set->packages.data;
krh@248
   638
	while (prop_iter_next(rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
krh@248
   639
		if (rpi->present[rp - rpi->start] & TRANS_PROPERTY_SATISFIED)
krh@248
   640
			continue;
krh@248
   641
krh@248
   642
		pp = prop_iter_seek_to(ppi, RAZOR_PROPERTY_PROVIDES,
krh@248
   643
				       &rpi->pool[rp->name]);
krh@248
   644
		if (pp == NULL)
krh@248
   645
			continue;
krh@248
   646
		pkg = pick_matching_provider(trans->upstream.set,
krh@248
   647
					     ppi, rp->flags,
krh@248
   648
					     &rpi->pool[rp->version]);
krh@248
   649
		if (pkg == NULL)
krh@248
   650
			continue;
krh@248
   651
krh@248
   652
		rpi->present[rp - rpi->start] |= TRANS_PROPERTY_SATISFIED;
krh@248
   653
ali@403
   654
#if 0
krh@257
   655
		fprintf(stderr, "pulling in %s-%s.%s which provides %s %s %s "
krh@248
   656
			"to satisfy %s %s %s\n",
krh@248
   657
			ppi->pool + pkg->name,
krh@257
   658
			ppi->pool + pkg->version,
krh@257
   659
			ppi->pool + pkg->arch,
krh@248
   660
			ppi->pool + pp->name,
krh@248
   661
			razor_property_relation_to_string(pp),
krh@248
   662
			ppi->pool + pp->version,
krh@248
   663
			&rpi->pool[rp->name],
krh@248
   664
			razor_property_relation_to_string(rp),
krh@248
   665
			&rpi->pool[rp->version]);
ali@403
   666
#endif
krh@248
   667
krh@248
   668
		trans->upstream.packages[pkg - upkgs] |= TRANS_PACKAGE_UPDATE;
krh@248
   669
	}
krh@248
   670
}
krh@248
   671
krh@248
   672
static void
krh@248
   673
pull_in_all_requirements(struct razor_transaction *trans)
krh@248
   674
{
krh@248
   675
	struct prop_iter rpi, ppi;
krh@248
   676
krh@248
   677
	prop_iter_init(&rpi, &trans->system);
krh@248
   678
	prop_iter_init(&ppi, &trans->upstream);
krh@248
   679
	pull_in_requirements(trans, &rpi, &ppi);
krh@248
   680
krh@248
   681
	prop_iter_init(&rpi, &trans->upstream);
krh@248
   682
	prop_iter_init(&ppi, &trans->upstream);
krh@248
   683
	pull_in_requirements(trans, &rpi, &ppi);
krh@248
   684
}
krh@248
   685
krh@248
   686
static void
krh@248
   687
flush_scheduled_system_updates(struct razor_transaction *trans)
krh@248
   688
{
krh@248
   689
 	struct razor_package_iterator *pi;
krh@248
   690
 	struct razor_package *p, *pkg, *spkgs;
krh@248
   691
	struct prop_iter ppi;
richard@302
   692
	const char *name, *version;
krh@248
   693
krh@248
   694
	spkgs = trans->system.set->packages.data;
krh@248
   695
	pi = razor_package_iterator_create(trans->system.set);
krh@248
   696
	prop_iter_init(&ppi, &trans->upstream);
krh@248
   697
richard@302
   698
	while (razor_package_iterator_next(pi, &p,
richard@302
   699
					   RAZOR_DETAIL_NAME, &name,
richard@307
   700
					   RAZOR_DETAIL_VERSION, &version,
richard@307
   701
					   RAZOR_DETAIL_LAST)) {
krh@248
   702
		if (!(trans->system.packages[p - spkgs] & TRANS_PACKAGE_UPDATE))
krh@248
   703
			continue;
ali@432
   704
		trans->system.packages[p - spkgs] &= ~TRANS_PACKAGE_UPDATE;
krh@248
   705
krh@248
   706
		if (!prop_iter_seek_to(&ppi, RAZOR_PROPERTY_PROVIDES, name))
krh@248
   707
			continue;
krh@248
   708
ali@386
   709
		if (any_provider_satisfies_requirement(&ppi,
ali@386
   710
						       RAZOR_PROPERTY_GREATER,
ali@386
   711
						       version)) {
ali@386
   712
			razor_transaction_remove_package(trans, p);
ali@386
   713
			continue;
ali@386
   714
		}
ali@386
   715
krh@248
   716
		pkg = pick_matching_provider(trans->upstream.set, &ppi,
krh@248
   717
					     RAZOR_PROPERTY_GREATER, version);
krh@248
   718
		if (pkg == NULL)
krh@248
   719
			continue;
krh@248
   720
krh@248
   721
		razor_transaction_remove_package(trans, p);
krh@248
   722
		razor_transaction_install_package(trans, pkg);
krh@248
   723
	}
krh@248
   724
krh@248
   725
	razor_package_iterator_destroy(pi);
krh@248
   726
}
krh@248
   727
krh@248
   728
static void
krh@248
   729
flush_scheduled_upstream_updates(struct razor_transaction *trans)
krh@248
   730
{
krh@248
   731
 	struct razor_package_iterator *pi;
krh@248
   732
 	struct razor_package *p, *upkgs;
krh@248
   733
	struct prop_iter spi;
richard@302
   734
	const char *name, *version;
krh@248
   735
krh@248
   736
	upkgs = trans->upstream.set->packages.data;
krh@248
   737
	pi = razor_package_iterator_create(trans->upstream.set);
krh@248
   738
	prop_iter_init(&spi, &trans->system);
krh@248
   739
richard@302
   740
	while (razor_package_iterator_next(pi, &p,
richard@302
   741
					   RAZOR_DETAIL_NAME, &name,
richard@307
   742
					   RAZOR_DETAIL_VERSION, &version,
richard@307
   743
					   RAZOR_DETAIL_LAST)) {
krh@248
   744
		if (!(trans->upstream.packages[p - upkgs] & TRANS_PACKAGE_UPDATE))
krh@248
   745
			continue;
ali@432
   746
		trans->upstream.packages[p - upkgs] &= ~TRANS_PACKAGE_UPDATE;
krh@248
   747
krh@248
   748
		if (prop_iter_seek_to(&spi, RAZOR_PROPERTY_PROVIDES, name))
krh@248
   749
			remove_matching_providers(trans,
krh@248
   750
						  &spi,
krh@248
   751
						  RAZOR_PROPERTY_LESS,
krh@248
   752
						  version);
krh@248
   753
		razor_transaction_install_package(trans, p);
ali@403
   754
#if 0
krh@248
   755
		fprintf(stderr, "installing %s-%s\n", name, version);
ali@403
   756
#endif
krh@248
   757
	}
krh@248
   758
}
krh@248
   759
krh@269
   760
RAZOR_EXPORT int
krh@248
   761
razor_transaction_resolve(struct razor_transaction *trans)
krh@248
   762
{
krh@248
   763
	int last = 0;
krh@248
   764
krh@248
   765
	flush_scheduled_system_updates(trans);
krh@248
   766
	flush_scheduled_upstream_updates(trans);
krh@248
   767
krh@248
   768
	while (last < trans->changes) {
krh@248
   769
		last = trans->changes;
krh@248
   770
		remove_obsoleted_packages(trans);
krh@248
   771
		mark_all_satisfied_requires(trans);
krh@248
   772
		update_unsatisfied_packages(trans);
krh@248
   773
		update_conflicted_packages(trans);
krh@248
   774
		pull_in_all_requirements(trans);
krh@248
   775
		flush_scheduled_system_updates(trans);
krh@248
   776
		flush_scheduled_upstream_updates(trans);
krh@248
   777
	}
krh@248
   778
krh@248
   779
	return trans->changes;
krh@248
   780
}
krh@248
   781
krh@248
   782
static void
krh@248
   783
describe_unsatisfied(struct razor_set *set, struct razor_property *rp)
krh@248
   784
{
krh@248
   785
	struct razor_package_iterator pi;
krh@248
   786
	struct razor_package *pkg;
krh@248
   787
	const char *name, *version, *arch, *pool;
krh@248
   788
krh@248
   789
	pool = set->string_pool.data;
krh@248
   790
	if (pool[rp->version] == '\0') {
krh@248
   791
		razor_package_iterator_init_for_property(&pi, set, rp);
krh@248
   792
		while (razor_package_iterator_next(&pi, &pkg,
richard@302
   793
						   RAZOR_DETAIL_NAME, &name,
richard@302
   794
						   RAZOR_DETAIL_VERSION, &version,
richard@307
   795
						   RAZOR_DETAIL_ARCH, &arch,
richard@307
   796
						   RAZOR_DETAIL_LAST))
krh@248
   797
			fprintf(stderr, "%s is needed by %s-%s.%s\n",
krh@248
   798
				&pool[rp->name],
krh@248
   799
				name, version, arch);
krh@248
   800
	} else {
krh@248
   801
		razor_package_iterator_init_for_property(&pi, set, rp);
krh@248
   802
		while (razor_package_iterator_next(&pi, &pkg,
richard@302
   803
						   RAZOR_DETAIL_NAME, &name,
richard@302
   804
						   RAZOR_DETAIL_VERSION, &version,
richard@307
   805
						   RAZOR_DETAIL_ARCH, &arch,
richard@307
   806
						   RAZOR_DETAIL_LAST))
krh@248
   807
			fprintf(stderr, "%s %s %s is needed by %s-%s.%s\n",
krh@248
   808
				&pool[rp->name],
krh@248
   809
				razor_property_relation_to_string(rp),
krh@248
   810
				&pool[rp->version],
krh@248
   811
				name, version, arch);
krh@248
   812
	}
krh@248
   813
}
krh@248
   814
krh@269
   815
RAZOR_EXPORT int
krh@248
   816
razor_transaction_describe(struct razor_transaction *trans)
krh@248
   817
{
krh@248
   818
	struct prop_iter rpi;
krh@248
   819
	struct razor_property *rp;
krh@248
   820
	int unsatisfied;
krh@248
   821
krh@248
   822
	flush_scheduled_system_updates(trans);
krh@248
   823
	flush_scheduled_upstream_updates(trans);
krh@248
   824
	mark_all_satisfied_requires(trans);
krh@248
   825
krh@248
   826
	unsatisfied = 0;
krh@248
   827
	prop_iter_init(&rpi, &trans->system);
krh@248
   828
	while (prop_iter_next(&rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
krh@248
   829
		if (!(rpi.present[rp - rpi.start] & TRANS_PROPERTY_SATISFIED)) {
krh@248
   830
			describe_unsatisfied(trans->system.set, rp);
krh@248
   831
		        unsatisfied++;
krh@248
   832
		}
krh@248
   833
	}
krh@248
   834
krh@248
   835
	prop_iter_init(&rpi, &trans->upstream);
krh@248
   836
	while (prop_iter_next(&rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
krh@248
   837
		if (!(rpi.present[rp - rpi.start] & TRANS_PROPERTY_SATISFIED)) {
krh@248
   838
			describe_unsatisfied(trans->upstream.set, rp);
krh@248
   839
			unsatisfied++;
krh@248
   840
		}
krh@248
   841
	}
krh@248
   842
krh@248
   843
	return unsatisfied;
krh@248
   844
}
krh@248
   845
krh@269
   846
RAZOR_EXPORT int
krh@248
   847
razor_transaction_unsatisfied_property(struct razor_transaction *trans,
krh@248
   848
				       const char *name,
krh@248
   849
				       uint32_t flags,
krh@248
   850
				       const char *version)
krh@248
   851
{
krh@248
   852
	struct prop_iter pi;
krh@248
   853
	struct razor_property *p;
krh@248
   854
krh@248
   855
	prop_iter_init(&pi, &trans->system);
jbowes@284
   856
	while (prop_iter_next(&pi, flags & RAZOR_PROPERTY_TYPE_MASK, &p)) {
krh@248
   857
		if (!(trans->system.properties[p - pi.start] & TRANS_PROPERTY_SATISFIED) &&
krh@248
   858
		    p->flags == flags &&
krh@248
   859
		    strcmp(&pi.pool[p->name], name) == 0 &&
krh@248
   860
		    strcmp(&pi.pool[p->version], version) == 0)
krh@248
   861
krh@248
   862
			return 1;
krh@248
   863
	}
krh@248
   864
krh@248
   865
	prop_iter_init(&pi, &trans->upstream);
jbowes@284
   866
	while (prop_iter_next(&pi, flags & RAZOR_PROPERTY_TYPE_MASK, &p)) {
krh@248
   867
		if (!(trans->upstream.properties[p - pi.start] & TRANS_PROPERTY_SATISFIED) &&
krh@248
   868
		    p->flags == flags &&
krh@248
   869
		    strcmp(&pi.pool[p->name], name) == 0 &&
krh@248
   870
		    strcmp(&pi.pool[p->version], version) == 0)
krh@248
   871
krh@248
   872
			return 1;
krh@248
   873
	}
krh@248
   874
krh@248
   875
	return 0;
krh@248
   876
}
krh@248
   877
krh@269
   878
RAZOR_EXPORT struct razor_set *
ali@369
   879
razor_transaction_commit(struct razor_transaction *trans)
krh@248
   880
{
krh@248
   881
	struct razor_package *u, *uend, *upkgs, *s, *send, *spkgs;
krh@248
   882
	char *upool, *spool;
krh@248
   883
	int cmp;
krh@248
   884
krh@248
   885
	s = trans->system.set->packages.data;
krh@248
   886
	spkgs = trans->system.set->packages.data;
krh@248
   887
	send = trans->system.set->packages.data +
krh@248
   888
		trans->system.set->packages.size;
krh@248
   889
	spool = trans->system.set->string_pool.data;
krh@248
   890
krh@248
   891
	u = trans->upstream.set->packages.data;
krh@248
   892
	upkgs = trans->upstream.set->packages.data;
krh@248
   893
	uend = trans->upstream.set->packages.data +
krh@248
   894
		trans->upstream.set->packages.size;
krh@248
   895
	upool = trans->upstream.set->string_pool.data;
krh@248
   896
ali@369
   897
	trans->merger = razor_merger_create(trans->system.set,
ali@369
   898
					    trans->upstream.set);
krh@248
   899
	while (s < send || u < uend) {
krh@248
   900
		if (s < send && u < uend)
krh@248
   901
			cmp = strcmp(&spool[s->name], &upool[u->name]);
krh@248
   902
		else if (s < send)
krh@248
   903
			cmp = -1;
krh@248
   904
		else
krh@248
   905
			cmp = 1;
krh@248
   906
krh@248
   907
		if (cmp < 0) {
krh@248
   908
			if (trans->system.packages[s - spkgs] & TRANS_PACKAGE_PRESENT)
ali@369
   909
				razor_merger_add_package(trans->merger, s);
krh@248
   910
			s++;
krh@248
   911
		} else if (cmp == 0) {
krh@248
   912
			if (trans->system.packages[s - spkgs] & TRANS_PACKAGE_PRESENT)
ali@369
   913
				razor_merger_add_package(trans->merger, s);
krh@248
   914
			if (trans->upstream.packages[u - upkgs] & TRANS_PACKAGE_PRESENT)
ali@369
   915
				razor_merger_add_package(trans->merger, u);
krh@248
   916
krh@248
   917
			s++;
krh@248
   918
			u++;
krh@248
   919
		} else {
krh@248
   920
			if (trans->upstream.packages[u - upkgs] & TRANS_PACKAGE_PRESENT)
ali@369
   921
				razor_merger_add_package(trans->merger, u);
krh@248
   922
			u++;
krh@248
   923
		}
krh@248
   924
	}
krh@248
   925
ali@369
   926
	return razor_merger_commit(trans->merger);
ali@369
   927
}
krh@248
   928
ali@369
   929
RAZOR_EXPORT void
ali@369
   930
razor_transaction_fixup_package(struct razor_transaction *trans,
ali@369
   931
				struct razor_package *package,
ali@369
   932
				struct razor_rpm *rpm)
ali@369
   933
{
ali@369
   934
	const char *preunprog, *preun, *postunprog, *postun;
ali@369
   935
ali@369
   936
	razor_rpm_get_details(rpm,
ali@369
   937
			      RAZOR_DETAIL_PREUNPROG, &preunprog,
ali@369
   938
			      RAZOR_DETAIL_PREUN, &preun,
ali@369
   939
			      RAZOR_DETAIL_POSTUNPROG, &postunprog,
ali@369
   940
			      RAZOR_DETAIL_POSTUN, &postun,
ali@369
   941
			      RAZOR_DETAIL_LAST);
ali@369
   942
ali@369
   943
	razor_merger_package_add_script(trans->merger, package,
ali@369
   944
					RAZOR_PROPERTY_PREUN,
ali@369
   945
					preunprog, preun);
ali@369
   946
	razor_merger_package_add_script(trans->merger, package,
ali@369
   947
					RAZOR_PROPERTY_POSTUN,
ali@369
   948
					postunprog, postun);
krh@248
   949
}
krh@248
   950
krh@269
   951
RAZOR_EXPORT void
krh@248
   952
razor_transaction_destroy(struct razor_transaction *trans)
krh@248
   953
{
richard@301
   954
	assert (trans != NULL);
richard@301
   955
ali@369
   956
	if (trans->merger)
ali@369
   957
		razor_merger_destroy(trans->merger);
krh@248
   958
	transaction_set_release(&trans->system);
krh@248
   959
	transaction_set_release(&trans->upstream);
krh@248
   960
	free(trans);
krh@248
   961
}