Fix bug causing updates to fail on systems with multiple versions of a package installed
2 * Copyright (C) 2008 Kristian Høgsberg <krh@redhat.com>
3 * Copyright (C) 2008 Red Hat, Inc
4 * Copyright (C) 2009 J. Ali Harlow <ali@juiblex.co.uk>
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation; either version 2 of the License, or
9 * (at your option) any later version.
11 * This program is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 * GNU General Public License for more details.
16 * You should have received a copy of the GNU General Public License along
17 * with this program; if not, write to the Free Software Foundation, Inc.,
18 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
23 #include "razor-internal.h"
26 #define UPSTREAM_SOURCE 0x80
29 struct razor_set *set;
30 uint32_t *property_map;
36 struct razor_set *set;
37 struct hashtable table;
38 struct hashtable file_table;
39 struct source source1;
40 struct source source2;
44 razor_merger_create(struct razor_set *set1, struct razor_set *set2)
46 struct razor_merger *merger;
50 merger = zalloc(sizeof *merger);
51 merger->set = razor_set_create();
52 hashtable_init(&merger->table, &merger->set->string_pool);
53 hashtable_init(&merger->file_table, &merger->set->file_string_pool);
55 merger->source1.set = set1;
56 count = set1->properties.size / sizeof (struct razor_property);
57 size = count * sizeof merger->source1.property_map[0];
58 merger->source1.property_map = zalloc(size);
59 count = set1->files.size / sizeof (struct razor_entry);
60 size = count * sizeof merger->source1.file_map[0];
61 merger->source1.file_map = zalloc(size);
63 merger->source2.set = set2;
64 count = set2->properties.size / sizeof (struct razor_property);
65 size = count * sizeof merger->source2.property_map[0];
66 merger->source2.property_map = zalloc(size);
67 count = set2->files.size / sizeof (struct razor_entry);
68 size = count * sizeof merger->source2.file_map[0];
69 merger->source2.file_map = zalloc(size);
75 razor_merger_add_package(struct razor_merger *merger,
76 struct razor_package *package)
80 struct razor_package *p;
81 struct razor_set *set1;
82 struct source *source;
83 uint32_t flags, *prefix;
84 struct array install_prefixes;
86 assert(merger->committed == 0);
88 set1 = merger->source1.set;
89 if (set1->packages.data <= (void *) package &&
90 (void *) package < set1->packages.data + set1->packages.size) {
91 source = &merger->source1;
94 source = &merger->source2;
95 flags = UPSTREAM_SOURCE;
98 pool = source->set->string_pool.data;
99 p = array_add(&merger->set->packages, sizeof *p);
100 p->name = hashtable_tokenize(&merger->table, &pool[package->name]);
102 p->version = hashtable_tokenize(&merger->table,
103 &pool[package->version]);
104 p->arch = hashtable_tokenize(&merger->table,
105 &pool[package->arch]);
107 p->properties = package->properties;
108 r = list_first(&package->properties, &source->set->property_pool);
110 source->property_map[r->data] = 1;
114 p->files = package->files;
115 r = list_first(&package->files, &source->set->file_pool);
117 source->file_map[r->data] = 1;
121 array_init(&install_prefixes);
122 r = list_first(&package->install_prefixes, &source->set->prefix_pool);
124 s = (char *)source->set->string_pool.data + r->data;
125 prefix = array_add(&install_prefixes, sizeof *prefix);
126 *prefix = hashtable_tokenize(&merger->table, s);
129 list_set_array(&p->install_prefixes, &merger->set->prefix_pool,
130 &install_prefixes, 0);
131 array_release(&install_prefixes);
133 p->preun.program = hashtable_tokenize(&merger->table,
134 &pool[package->preun.program]);
135 p->preun.body = hashtable_tokenize(&merger->table,
136 &pool[package->preun.body]);
137 p->postun.program = hashtable_tokenize(&merger->table,
138 &pool[package->postun.program]);
139 p->postun.body = hashtable_tokenize(&merger->table,
140 &pool[package->postun.body]);
144 add_property(struct razor_merger *merger,
145 const char *name, uint32_t flags, const char *version)
147 struct razor_property *p;
149 p = array_add(&merger->set->properties, sizeof *p);
150 p->name = hashtable_tokenize(&merger->table, name);
152 p->version = hashtable_tokenize(&merger->table, version);
154 return p - (struct razor_property *) merger->set->properties.data;
158 merge_properties(struct razor_merger *merger)
160 struct razor_property *p1, *p2;
161 struct razor_set *set1, *set2;
162 uint32_t *map1, *map2;
163 int i, j, cmp, count1, count2;
166 set1 = merger->source1.set;
167 set2 = merger->source2.set;
168 map1 = merger->source1.property_map;
169 map2 = merger->source2.property_map;
173 pool1 = set1->string_pool.data;
174 pool2 = set2->string_pool.data;
176 count1 = set1->properties.size / sizeof *p1;
177 count2 = set2->properties.size / sizeof *p2;
178 while (i < count1 || j < count2) {
179 if (i < count1 && map1[i] == 0) {
183 if (j < count2 && map2[j] == 0) {
187 p1 = (struct razor_property *) set1->properties.data + i;
188 p2 = (struct razor_property *) set2->properties.data + j;
189 if (i < count1 && j < count2)
190 cmp = strcmp(&pool1[p1->name], &pool2[p2->name]);
196 cmp = p1->flags - p2->flags;
198 cmp = razor_versioncmp(&pool1[p1->version],
199 &pool2[p2->version]);
201 map1[i++] = add_property(merger,
204 &pool1[p1->version]);
205 } else if (cmp > 0) {
206 map2[j++] = add_property(merger,
209 &pool2[p2->version]);
211 map1[i++] = map2[j++] =
215 &pool1[p1->version]);
221 emit_properties(struct list_head *properties, struct array *source_pool,
222 uint32_t *map, struct array *pool)
227 r = pool->size / sizeof *q;
228 p = list_first(properties, source_pool);
230 q = array_add(pool, sizeof *q);
231 q->data = map[p->data];
236 list_set_ptr(properties, r);
240 add_file(struct razor_merger *merger, const char *name)
242 struct razor_entry *e;
244 e = array_add(&merger->set->files, sizeof *e);
245 e->name = hashtable_tokenize(&merger->file_table, name);
249 return e - (struct razor_entry *)merger->set->files.data;
254 fix_file_map(uint32_t *map,
255 struct razor_entry *files,
256 struct razor_entry *top)
263 if (files[e].start &&
264 fix_file_map(map, files, &files[files[e].start]))
268 } while (!(files[e++].flags & RAZOR_ENTRY_LAST));
273 struct merge_directory {
274 uint32_t merged, dir1, dir2;
278 merge_one_directory(struct razor_merger *merger, struct merge_directory *md)
280 struct razor_entry *root1, *root2, *mroot, *e1, *e2;
281 struct razor_set *set1, *set2;
282 struct array merge_stack;
283 struct merge_directory *child_md, *end_md;
284 uint32_t *map1, *map2, start, last;
288 set1 = merger->source1.set;
289 set2 = merger->source2.set;
290 map1 = merger->source1.file_map;
291 map2 = merger->source2.file_map;
292 pool1 = set1->file_string_pool.data;
293 pool2 = set2->file_string_pool.data;
294 root1 = (struct razor_entry *) set1->files.data;
295 root2 = (struct razor_entry *) set2->files.data;
297 array_init(&merge_stack);
299 start = merger->set->files.size / sizeof (struct razor_entry);
301 e1 = md->dir1 != 0xFFFFFFFF ? root1 + md->dir1 : NULL;
302 e2 = md->dir2 != 0xFFFFFFFF ? root2 + md->dir2 : NULL;
304 if (!e2 && !map1[e1 - root1]) {
305 if ((e1++)->flags & RAZOR_ENTRY_LAST)
309 if (!e1 && !map2[e2 - root2]) {
310 if ((e2++)->flags & RAZOR_ENTRY_LAST)
314 if (e1 && !map1[e1 - root1] &&
315 e2 && !map2[e2 - root2]) {
316 if ((e1++)->flags & RAZOR_ENTRY_LAST)
318 if ((e2++)->flags & RAZOR_ENTRY_LAST)
328 cmp = strcmp (&pool1[e1->name],
333 if (map1[e1 - root1]) {
334 map1[e1 - root1] = last =
335 add_file(merger, &pool1[e1->name]);
337 child_md = array_add(&merge_stack, sizeof (struct merge_directory));
338 child_md->merged = last;
339 child_md->dir1 = e1->start;
340 child_md->dir2 = 0xFFFFFFFF;
343 if ((e1++)->flags & RAZOR_ENTRY_LAST)
345 } else if (cmp > 0) {
346 if (map2[e2 - root2]) {
347 map2[e2 - root2] = last =
348 add_file(merger, &pool2[e2->name]);
350 child_md = array_add(&merge_stack, sizeof (struct merge_directory));
351 child_md->merged = last;
352 child_md->dir1 = 0xFFFFFFFF;
353 child_md->dir2 = e2->start;
356 if ((e2++)->flags & RAZOR_ENTRY_LAST)
359 map1[e1 - root1] = map2[e2- root2] = last =
360 add_file(merger, &pool1[e1->name]);
361 if (e1->start || e2->start) {
362 child_md = array_add(&merge_stack, sizeof (struct merge_directory));
363 child_md->merged = last;
364 child_md->dir1 = e1->start ? e1->start : 0xFFFFFFFF;
365 child_md->dir2 = e2->start ? e2->start : 0xFFFFFFFF;
367 if ((e1++)->flags & RAZOR_ENTRY_LAST)
369 if ((e2++)->flags & RAZOR_ENTRY_LAST)
374 mroot = (struct razor_entry *)merger->set->files.data;
375 if (last != 0xFFFFFFFF) {
376 mroot[last].flags = RAZOR_ENTRY_LAST;
377 mroot[md->merged].start = start;
380 end_md = merge_stack.data + merge_stack.size;
381 for (child_md = merge_stack.data; child_md < end_md; child_md++)
382 merge_one_directory(merger, child_md);
383 array_release(&merge_stack);
387 merge_files(struct razor_merger *merger)
389 struct razor_entry *root;
390 struct merge_directory md;
391 uint32_t *map1, *map2;
393 map1 = merger->source1.file_map;
394 map2 = merger->source2.file_map;
398 if (merger->source1.set->files.size) {
399 root = (struct razor_entry *) merger->source1.set->files.data;
401 fix_file_map(map1, root, root);
404 md.dir1 = 0xFFFFFFFF;
407 if (merger->source2.set->files.size) {
408 root = (struct razor_entry *) merger->source2.set->files.data;
410 fix_file_map(map2, root, root);
413 md.dir2 = 0xFFFFFFFF;
416 /* Remove the unnamed root which razor_set_create() added */
417 array_release(&merger->set->files);
418 array_init(&merger->set->files);
420 merge_one_directory(merger, &md);
424 emit_files(struct list_head *files, struct array *source_pool,
425 uint32_t *map, struct array *pool)
430 r = pool->size / sizeof *q;
431 p = list_first(files, source_pool);
433 q = array_add(pool, sizeof *q);
434 q->data = map[p->data];
439 list_set_ptr(files, r);
442 /* Rebuild property->packages maps. We can't just remap these, as a
443 * property may have lost or gained a number of packages. Allocate an
444 * array per property and loop through the packages and add them to
445 * the arrays for their properties. */
447 rebuild_property_package_lists(struct razor_set *set)
449 struct array *pkgs, *a;
450 struct razor_package *pkg, *pkg_end;
451 struct razor_property *prop, *prop_end;
456 count = set->properties.size / sizeof (struct razor_property);
457 pkgs = zalloc(count * sizeof *pkgs);
458 pkg_end = set->packages.data + set->packages.size;
460 for (pkg = set->packages.data; pkg < pkg_end; pkg++) {
461 r = list_first(&pkg->properties, &set->property_pool);
463 q = array_add(&pkgs[r->data], sizeof *q);
464 *q = pkg - (struct razor_package *) set->packages.data;
469 prop_end = set->properties.data + set->properties.size;
471 for (prop = set->properties.data; prop < prop_end; prop++, a++) {
472 list_set_array(&prop->packages, &set->package_pool, a, 0);
479 rebuild_file_package_lists(struct razor_set *set)
481 struct array *pkgs, *a;
482 struct razor_package *pkg, *pkg_end;
483 struct razor_entry *entry, *entry_end;
488 count = set->files.size / sizeof (struct razor_entry);
489 pkgs = zalloc(count * sizeof *pkgs);
490 pkg_end = set->packages.data + set->packages.size;
492 for (pkg = set->packages.data; pkg < pkg_end; pkg++) {
493 r = list_first(&pkg->files, &set->file_pool);
495 q = array_add(&pkgs[r->data], sizeof *q);
496 *q = pkg - (struct razor_package *) set->packages.data;
501 entry_end = set->files.data + set->files.size;
503 for (entry = set->files.data; entry < entry_end; entry++, a++) {
504 list_set_array(&entry->packages, &set->package_pool, a, 0);
511 razor_merger_commit(struct razor_merger *merger)
513 struct razor_package *p, *pend;
515 /* As we built the package list, we filled out a bitvector of
516 * the properties that are referenced by the packages in the
517 * new set. Now we do a parallel loop through the properties
518 * and emit those marked in the bit vector to the new set. In
519 * the process, we update the bit vector to actually map from
520 * indices in the old property list to indices in the new
521 * property list for both sets. */
523 merge_properties(merger);
526 /* Now we loop through the packages again and emit the
527 * property lists, remapped to point to the new properties. */
529 pend = merger->set->packages.data + merger->set->packages.size;
530 for (p = merger->set->packages.data; p < pend; p++) {
533 if (p->flags & UPSTREAM_SOURCE)
534 src = &merger->source2;
536 src = &merger->source1;
538 emit_properties(&p->properties,
539 &src->set->property_pool,
541 &merger->set->property_pool);
542 emit_files(&p->files,
543 &src->set->file_pool,
545 &merger->set->file_pool);
546 p->flags &= ~UPSTREAM_SOURCE;
549 rebuild_property_package_lists(merger->set);
550 rebuild_file_package_lists(merger->set);
552 merger->committed = 1;
558 razor_merger_package_add_script(struct razor_merger *merger,
559 struct razor_package *package,
560 enum razor_property_flags script,
561 const char *program, const char *body)
565 struct razor_set *set = merger->set;
566 assert ((void *)package >= set->packages.data && \
567 (void *)package < set->packages.data + set->packages.size);
569 p = hashtable_tokenize(&merger->table, program);
570 b = hashtable_tokenize(&merger->table, body);
572 pool = merger->set->string_pool.data;
575 case RAZOR_PROPERTY_PREUN:
576 assert(pool[package->preun.program] == '\0');
577 assert(pool[package->preun.body] == '\0');
578 package->preun.program = p;
579 package->preun.body = b;
581 case RAZOR_PROPERTY_POSTUN:
582 assert(pool[package->postun.program] == '\0');
583 assert(pool[package->postun.body] == '\0');
584 package->postun.program = p;
585 package->postun.body = b;
592 void razor_merger_destroy(struct razor_merger *merger)
594 hashtable_release(&merger->table);
595 hashtable_release(&merger->file_table);