Tweak razor search a bit: casefold, print summary, search rawhide instead.
2 * Copyright (C) 2008 Kristian Høgsberg <krh@redhat.com>
3 * Copyright (C) 2008 Red Hat, Inc
5 * This program is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License as published by
7 * the Free Software Foundation; either version 2 of the License, or
8 * (at your option) any later version.
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
15 * You should have received a copy of the GNU General Public License along
16 * with this program; if not, write to the Free Software Foundation, Inc.,
17 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
27 #include <sys/types.h>
37 #include "razor-internal.h"
41 provider_satisfies_requirement(struct razor_property *provider,
42 const char *provider_strings,
47 const char *provided = &provider_strings[provider->version];
52 if (flags & RAZOR_PROPERTY_LESS)
58 cmp = razor_versioncmp(provided, required);
60 switch (flags & RAZOR_PROPERTY_RELATION_MASK) {
61 case RAZOR_PROPERTY_LESS:
64 case RAZOR_PROPERTY_LESS | RAZOR_PROPERTY_EQUAL:
67 /* fall through: FIXME, make sure this is correct */
69 case RAZOR_PROPERTY_EQUAL:
73 /* "foo == 1.1" is satisfied by "foo 1.1-2" */
74 len = strlen(required);
75 if (!strncmp(required, provided, len) && provided[len] == '-')
79 case RAZOR_PROPERTY_GREATER | RAZOR_PROPERTY_EQUAL:
82 case RAZOR_PROPERTY_GREATER:
86 /* shouldn't happen */
90 #define TRANS_PACKAGE_PRESENT 1
91 #define TRANS_PACKAGE_UPDATE 2
92 #define TRANS_PROPERTY_SATISFIED 0x80000000
94 struct transaction_set {
95 struct razor_set *set;
100 struct razor_transaction {
101 int package_count, errors;
102 struct transaction_set system, upstream;
107 transaction_set_init(struct transaction_set *ts, struct razor_set *set)
112 count = set->packages.size / sizeof (struct razor_package);
113 ts->packages = zalloc(count * sizeof *ts->packages);
114 count = set->properties.size / sizeof (struct razor_property);
115 ts->properties = zalloc(count * sizeof *ts->properties);
119 transaction_set_release(struct transaction_set *ts)
122 free(ts->properties);
126 transaction_set_install_package(struct transaction_set *ts,
127 struct razor_package *package)
129 struct razor_package *pkgs;
133 pkgs = ts->set->packages.data;
135 if (ts->packages[i] == TRANS_PACKAGE_PRESENT)
138 ts->packages[i] = TRANS_PACKAGE_PRESENT;
140 prop = list_first(&package->properties, &ts->set->property_pool);
142 ts->properties[prop->data]++;
143 prop = list_next(prop);
148 transaction_set_remove_package(struct transaction_set *ts,
149 struct razor_package *package)
151 struct razor_package *pkgs;
155 pkgs = ts->set->packages.data;
157 if (ts->packages[i] == 0)
162 prop = list_first(&package->properties, &ts->set->property_pool);
164 ts->properties[prop->data]--;
165 prop = list_next(prop);
169 RAZOR_EXPORT struct razor_transaction *
170 razor_transaction_create(struct razor_set *system, struct razor_set *upstream)
172 struct razor_transaction *trans;
173 struct razor_package *p, *spkgs, *pend;
175 trans = zalloc(sizeof *trans);
176 transaction_set_init(&trans->system, system);
177 transaction_set_init(&trans->upstream, upstream);
179 spkgs = trans->system.set->packages.data;
180 pend = trans->system.set->packages.data +
181 trans->system.set->packages.size;
182 for (p = spkgs; p < pend; p++)
183 transaction_set_install_package(&trans->system, p);
189 razor_transaction_install_package(struct razor_transaction *trans,
190 struct razor_package *package)
192 assert (trans != NULL);
193 assert (package != NULL);
195 transaction_set_install_package(&trans->upstream, package);
200 razor_transaction_remove_package(struct razor_transaction *trans,
201 struct razor_package *package)
203 assert (trans != NULL);
204 assert (package != NULL);
206 transaction_set_remove_package(&trans->system, package);
211 razor_transaction_update_package(struct razor_transaction *trans,
212 struct razor_package *package)
214 struct razor_package *spkgs, *upkgs, *end;
216 assert (trans != NULL);
217 assert (package != NULL);
219 spkgs = trans->system.set->packages.data;
220 upkgs = trans->upstream.set->packages.data;
221 end = trans->system.set->packages.data +
222 trans->system.set->packages.size;
223 if (spkgs <= package && package < end)
224 trans->system.packages[package - spkgs] |= TRANS_PACKAGE_UPDATE;
226 trans->upstream.packages[package - upkgs] |= TRANS_PACKAGE_UPDATE;
230 struct razor_property *p, *start, *end;
236 prop_iter_init(struct prop_iter *pi, struct transaction_set *ts)
238 pi->p = ts->set->properties.data;
239 pi->start = ts->set->properties.data;
240 pi->end = ts->set->properties.data + ts->set->properties.size;
241 pi->pool = ts->set->string_pool.data;
242 pi->present = ts->properties;
246 prop_iter_next(struct prop_iter *pi, uint32_t flags, struct razor_property **p)
248 while (pi->p < pi->end) {
249 if ((pi->present[pi->p - pi->start] & ~TRANS_PROPERTY_SATISFIED) &&
250 (pi->p->flags & RAZOR_PROPERTY_TYPE_MASK) == flags) {
260 static struct razor_property *
261 prop_iter_seek_to(struct prop_iter *pi,
262 uint32_t flags, const char *match)
266 while (pi->p < pi->end && strcmp(&pi->pool[pi->p->name], match) < 0)
269 if (pi->p == pi->end || strcmp(&pi->pool[pi->p->name], match) > 0)
273 while (pi->p < pi->end &&
274 pi->p->name == name &&
275 (pi->p->flags & RAZOR_PROPERTY_TYPE_MASK) != flags)
278 if (pi->p == pi->end || pi->p->name != name)
284 /* Remove packages from set that provide any of the matching (same
285 * name and type) providers from ppi onwards that match the
286 * requirement that rpi points to. */
288 remove_matching_providers(struct razor_transaction *trans,
289 struct prop_iter *ppi,
293 struct razor_property *p;
294 struct razor_package *pkg, *pkgs;
295 struct razor_package_iterator pkg_iter;
296 struct razor_set *set;
300 if (ppi->present == trans->system.properties)
301 set = trans->system.set;
303 set = trans->upstream.set;
305 pkgs = (struct razor_package *) set->packages.data;
306 type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
309 p->name == ppi->p->name &&
310 (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type;
312 if (!ppi->present[p - ppi->start])
314 if (!provider_satisfies_requirement(p, ppi->pool,
318 razor_package_iterator_init_for_property(&pkg_iter, set, p);
319 while (razor_package_iterator_next(&pkg_iter, &pkg,
320 RAZOR_DETAIL_NAME, &n,
321 RAZOR_DETAIL_VERSION, &v, NULL)) {
322 fprintf(stderr, "removing %s-%s\n", n, v);
323 razor_transaction_remove_package(trans, pkg);
329 flag_matching_providers(struct razor_transaction *trans,
330 struct prop_iter *ppi,
331 struct razor_property *r,
332 struct prop_iter *rpi,
335 struct razor_property *p;
336 struct razor_package *pkg, *pkgs;
337 struct razor_package_iterator pkg_iter;
338 struct razor_set *set;
339 const char *name, *version;
340 uint32_t *flags, type;
342 if (ppi->present == trans->system.properties) {
343 set = trans->system.set;
344 flags = trans->system.packages;
346 set = trans->upstream.set;
347 flags = trans->upstream.packages;
350 pkgs = (struct razor_package *) set->packages.data;
351 type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
354 p->name == ppi->p->name &&
355 (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type;
357 if (!ppi->present[p - ppi->start])
359 if (!provider_satisfies_requirement(p, ppi->pool,
361 &rpi->pool[r->version]))
364 razor_package_iterator_init_for_property(&pkg_iter, set, p);
365 while (razor_package_iterator_next(&pkg_iter, &pkg,
366 RAZOR_DETAIL_NAME, &name,
367 RAZOR_DETAIL_VERSION, &version, NULL)) {
369 fprintf(stderr, "flagging %s-%s for providing %s matching %s %s\n",
373 rpi->pool + r->version);
374 flags[pkg - pkgs] |= flag;
379 static struct razor_package *
380 pick_matching_provider(struct razor_set *set,
381 struct prop_iter *ppi,
385 struct razor_property *p;
386 struct razor_package *pkgs;
390 /* This is where we decide which pkgs to pull in to satisfy a
391 * requirement. There may be several different providers
392 * (different versions) and each version of a provider may
393 * come from a number of packages. We pick the first package
394 * from the first provider that matches. */
396 pkgs = set->packages.data;
397 type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
400 p->name == ppi->p->name &&
401 (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type &&
402 ppi->present[p - ppi->start] == 0;
404 if (!provider_satisfies_requirement(p, ppi->pool,
408 i = list_first(&p->packages, &set->package_pool);
410 return &pkgs[i->data];
417 remove_obsoleted_packages(struct razor_transaction *trans)
419 struct razor_property *up;
420 struct razor_package *spkgs;
421 struct prop_iter spi, upi;
423 spkgs = trans->system.set->packages.data;
424 prop_iter_init(&spi, &trans->system);
425 prop_iter_init(&upi, &trans->upstream);
427 while (prop_iter_next(&upi, RAZOR_PROPERTY_OBSOLETES, &up)) {
428 if (!prop_iter_seek_to(&spi, RAZOR_PROPERTY_PROVIDES,
429 &upi.pool[up->name]))
431 remove_matching_providers(trans, &spi, up->flags,
432 &upi.pool[up->version]);
437 any_provider_satisfies_requirement(struct prop_iter *ppi,
441 struct razor_property *p;
444 type = ppi->p->flags & RAZOR_PROPERTY_TYPE_MASK;
447 p->name == ppi->p->name &&
448 (p->flags & RAZOR_PROPERTY_TYPE_MASK) == type;
450 if (ppi->present[p - ppi->start] > 0 &&
451 provider_satisfies_requirement(p, ppi->pool,
460 clear_requires_flags(struct transaction_set *ts)
462 struct razor_property *p;
466 count = ts->set->properties.size / sizeof *p;
467 p = ts->set->properties.data;
468 pool = ts->set->string_pool.data;
469 for (i = 0; i < count; i++) {
470 ts->properties[i] &= ~TRANS_PROPERTY_SATISFIED;
471 if (strncmp(&pool[p[i].name], "rpmlib(", 7) == 0)
472 ts->properties[i] |= TRANS_PROPERTY_SATISFIED;
477 mark_satisfied_requires(struct razor_transaction *trans,
478 struct transaction_set *rts,
479 struct transaction_set *pts)
481 struct prop_iter rpi, ppi;
482 struct razor_property *rp;
484 prop_iter_init(&rpi, rts);
485 prop_iter_init(&ppi, pts);
487 while (prop_iter_next(&rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
488 if (!prop_iter_seek_to(&ppi, RAZOR_PROPERTY_PROVIDES,
489 &rpi.pool[rp->name]))
492 if (any_provider_satisfies_requirement(&ppi, rp->flags,
493 &rpi.pool[rp->version]))
494 rpi.present[rp - rpi.start] |= TRANS_PROPERTY_SATISFIED;
499 mark_all_satisfied_requires(struct razor_transaction *trans)
501 clear_requires_flags(&trans->system);
502 clear_requires_flags(&trans->upstream);
503 mark_satisfied_requires(trans, &trans->system, &trans->system);
504 mark_satisfied_requires(trans, &trans->system, &trans->upstream);
505 mark_satisfied_requires(trans, &trans->upstream, &trans->system);
506 mark_satisfied_requires(trans, &trans->upstream, &trans->upstream);
510 update_unsatisfied_packages(struct razor_transaction *trans)
512 struct razor_package *spkgs, *pkg;
513 struct razor_property *sp;
514 struct prop_iter spi;
515 struct razor_package_iterator pkg_iter;
518 spkgs = trans->system.set->packages.data;
519 prop_iter_init(&spi, &trans->system);
521 while (prop_iter_next(&spi, RAZOR_PROPERTY_REQUIRES, &sp)) {
522 if (spi.present[sp - spi.start] & TRANS_PROPERTY_SATISFIED)
525 razor_package_iterator_init_for_property(&pkg_iter,
528 while (razor_package_iterator_next(&pkg_iter, &pkg,
529 RAZOR_DETAIL_NAME, &name, NULL)) {
530 fprintf(stderr, "updating %s because %s %s %s "
532 name, spi.pool + sp->name,
533 razor_property_relation_to_string(sp),
534 spi.pool + sp->version);
535 trans->system.packages[pkg - spkgs] |=
536 TRANS_PACKAGE_UPDATE;
542 razor_transaction_update_all(struct razor_transaction *trans)
544 struct razor_package *p;
547 assert (trans != NULL);
549 count = trans->system.set->packages.size / sizeof *p;
550 for (i = 0; i < count; i++)
551 trans->system.packages[i] |= TRANS_PACKAGE_UPDATE;
555 update_conflicted_packages(struct razor_transaction *trans)
557 struct razor_package *pkg, *spkgs;
558 struct razor_property *up, *sp;
559 struct prop_iter spi, upi;
560 struct razor_package_iterator pkg_iter;
561 const char *name, *version;
563 spkgs = trans->system.set->packages.data;
564 prop_iter_init(&spi, &trans->system);
565 prop_iter_init(&upi, &trans->upstream);
567 while (prop_iter_next(&spi, RAZOR_PROPERTY_CONFLICTS, &sp)) {
568 if (!prop_iter_seek_to(&upi, RAZOR_PROPERTY_PROVIDES,
569 &spi.pool[sp->name]))
572 if (!any_provider_satisfies_requirement(&upi, sp->flags,
573 &spi.pool[sp->version]))
576 razor_package_iterator_init_for_property(&pkg_iter,
579 while (razor_package_iterator_next(&pkg_iter, &pkg,
580 RAZOR_DETAIL_NAME, &name,
581 RAZOR_DETAIL_VERSION, &version, NULL)) {
582 fprintf(stderr, "updating %s %s because it "
583 "conflicts with %s\n",
584 name, version, spi.pool + sp->name);
585 trans->system.packages[pkg - spkgs] |=
586 TRANS_PACKAGE_UPDATE;
590 prop_iter_init(&spi, &trans->system);
591 prop_iter_init(&upi, &trans->upstream);
593 while (prop_iter_next(&upi, RAZOR_PROPERTY_CONFLICTS, &up)) {
594 sp = prop_iter_seek_to(&spi, RAZOR_PROPERTY_PROVIDES,
595 &upi.pool[upi.p->name]);
598 flag_matching_providers(trans, &spi, up, &upi,
599 TRANS_PACKAGE_UPDATE);
604 pull_in_requirements(struct razor_transaction *trans,
605 struct prop_iter *rpi, struct prop_iter *ppi)
607 struct razor_property *rp, *pp;
608 struct razor_package *pkg, *upkgs;
610 upkgs = trans->upstream.set->packages.data;
611 while (prop_iter_next(rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
612 if (rpi->present[rp - rpi->start] & TRANS_PROPERTY_SATISFIED)
615 pp = prop_iter_seek_to(ppi, RAZOR_PROPERTY_PROVIDES,
616 &rpi->pool[rp->name]);
619 pkg = pick_matching_provider(trans->upstream.set,
621 &rpi->pool[rp->version]);
625 rpi->present[rp - rpi->start] |= TRANS_PROPERTY_SATISFIED;
627 fprintf(stderr, "pulling in %s-%s.%s which provides %s %s %s "
628 "to satisfy %s %s %s\n",
629 ppi->pool + pkg->name,
630 ppi->pool + pkg->version,
631 ppi->pool + pkg->arch,
632 ppi->pool + pp->name,
633 razor_property_relation_to_string(pp),
634 ppi->pool + pp->version,
635 &rpi->pool[rp->name],
636 razor_property_relation_to_string(rp),
637 &rpi->pool[rp->version]);
639 trans->upstream.packages[pkg - upkgs] |= TRANS_PACKAGE_UPDATE;
644 pull_in_all_requirements(struct razor_transaction *trans)
646 struct prop_iter rpi, ppi;
648 prop_iter_init(&rpi, &trans->system);
649 prop_iter_init(&ppi, &trans->upstream);
650 pull_in_requirements(trans, &rpi, &ppi);
652 prop_iter_init(&rpi, &trans->upstream);
653 prop_iter_init(&ppi, &trans->upstream);
654 pull_in_requirements(trans, &rpi, &ppi);
658 flush_scheduled_system_updates(struct razor_transaction *trans)
660 struct razor_package_iterator *pi;
661 struct razor_package *p, *pkg, *spkgs;
662 struct prop_iter ppi;
663 const char *name, *version;
665 spkgs = trans->system.set->packages.data;
666 pi = razor_package_iterator_create(trans->system.set);
667 prop_iter_init(&ppi, &trans->upstream);
669 while (razor_package_iterator_next(pi, &p,
670 RAZOR_DETAIL_NAME, &name,
671 RAZOR_DETAIL_VERSION, &version, NULL)) {
672 if (!(trans->system.packages[p - spkgs] & TRANS_PACKAGE_UPDATE))
675 if (!prop_iter_seek_to(&ppi, RAZOR_PROPERTY_PROVIDES, name))
678 pkg = pick_matching_provider(trans->upstream.set, &ppi,
679 RAZOR_PROPERTY_GREATER, version);
683 fprintf(stderr, "updating %s-%s to %s-%s\n",
685 &ppi.pool[pkg->name], &ppi.pool[pkg->version]);
687 razor_transaction_remove_package(trans, p);
688 razor_transaction_install_package(trans, pkg);
691 razor_package_iterator_destroy(pi);
695 flush_scheduled_upstream_updates(struct razor_transaction *trans)
697 struct razor_package_iterator *pi;
698 struct razor_package *p, *upkgs;
699 struct prop_iter spi;
700 const char *name, *version;
702 upkgs = trans->upstream.set->packages.data;
703 pi = razor_package_iterator_create(trans->upstream.set);
704 prop_iter_init(&spi, &trans->system);
706 while (razor_package_iterator_next(pi, &p,
707 RAZOR_DETAIL_NAME, &name,
708 RAZOR_DETAIL_VERSION, &version, NULL)) {
709 if (!(trans->upstream.packages[p - upkgs] & TRANS_PACKAGE_UPDATE))
712 if (prop_iter_seek_to(&spi, RAZOR_PROPERTY_PROVIDES, name))
713 remove_matching_providers(trans,
717 razor_transaction_install_package(trans, p);
718 fprintf(stderr, "installing %s-%s\n", name, version);
723 razor_transaction_resolve(struct razor_transaction *trans)
727 flush_scheduled_system_updates(trans);
728 flush_scheduled_upstream_updates(trans);
730 while (last < trans->changes) {
731 last = trans->changes;
732 remove_obsoleted_packages(trans);
733 mark_all_satisfied_requires(trans);
734 update_unsatisfied_packages(trans);
735 update_conflicted_packages(trans);
736 pull_in_all_requirements(trans);
737 flush_scheduled_system_updates(trans);
738 flush_scheduled_upstream_updates(trans);
741 return trans->changes;
745 describe_unsatisfied(struct razor_set *set, struct razor_property *rp)
747 struct razor_package_iterator pi;
748 struct razor_package *pkg;
749 const char *name, *version, *arch, *pool;
751 pool = set->string_pool.data;
752 if (pool[rp->version] == '\0') {
753 razor_package_iterator_init_for_property(&pi, set, rp);
754 while (razor_package_iterator_next(&pi, &pkg,
755 RAZOR_DETAIL_NAME, &name,
756 RAZOR_DETAIL_VERSION, &version,
757 RAZOR_DETAIL_ARCH, &arch, NULL))
758 fprintf(stderr, "%s is needed by %s-%s.%s\n",
760 name, version, arch);
762 razor_package_iterator_init_for_property(&pi, set, rp);
763 while (razor_package_iterator_next(&pi, &pkg,
764 RAZOR_DETAIL_NAME, &name,
765 RAZOR_DETAIL_VERSION, &version,
766 RAZOR_DETAIL_ARCH, &arch, NULL))
767 fprintf(stderr, "%s %s %s is needed by %s-%s.%s\n",
769 razor_property_relation_to_string(rp),
771 name, version, arch);
776 razor_transaction_describe(struct razor_transaction *trans)
778 struct prop_iter rpi;
779 struct razor_property *rp;
782 flush_scheduled_system_updates(trans);
783 flush_scheduled_upstream_updates(trans);
784 mark_all_satisfied_requires(trans);
787 prop_iter_init(&rpi, &trans->system);
788 while (prop_iter_next(&rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
789 if (!(rpi.present[rp - rpi.start] & TRANS_PROPERTY_SATISFIED)) {
790 describe_unsatisfied(trans->system.set, rp);
795 prop_iter_init(&rpi, &trans->upstream);
796 while (prop_iter_next(&rpi, RAZOR_PROPERTY_REQUIRES, &rp)) {
797 if (!(rpi.present[rp - rpi.start] & TRANS_PROPERTY_SATISFIED)) {
798 describe_unsatisfied(trans->upstream.set, rp);
807 razor_transaction_unsatisfied_property(struct razor_transaction *trans,
813 struct razor_property *p;
815 prop_iter_init(&pi, &trans->system);
816 while (prop_iter_next(&pi, flags & RAZOR_PROPERTY_TYPE_MASK, &p)) {
817 if (!(trans->system.properties[p - pi.start] & TRANS_PROPERTY_SATISFIED) &&
819 strcmp(&pi.pool[p->name], name) == 0 &&
820 strcmp(&pi.pool[p->version], version) == 0)
825 prop_iter_init(&pi, &trans->upstream);
826 while (prop_iter_next(&pi, flags & RAZOR_PROPERTY_TYPE_MASK, &p)) {
827 if (!(trans->upstream.properties[p - pi.start] & TRANS_PROPERTY_SATISFIED) &&
829 strcmp(&pi.pool[p->name], name) == 0 &&
830 strcmp(&pi.pool[p->version], version) == 0)
838 RAZOR_EXPORT struct razor_set *
839 razor_transaction_finish(struct razor_transaction *trans)
841 struct razor_merger *merger;
842 struct razor_package *u, *uend, *upkgs, *s, *send, *spkgs;
846 s = trans->system.set->packages.data;
847 spkgs = trans->system.set->packages.data;
848 send = trans->system.set->packages.data +
849 trans->system.set->packages.size;
850 spool = trans->system.set->string_pool.data;
852 u = trans->upstream.set->packages.data;
853 upkgs = trans->upstream.set->packages.data;
854 uend = trans->upstream.set->packages.data +
855 trans->upstream.set->packages.size;
856 upool = trans->upstream.set->string_pool.data;
858 merger = razor_merger_create(trans->system.set, trans->upstream.set);
859 while (s < send || u < uend) {
860 if (s < send && u < uend)
861 cmp = strcmp(&spool[s->name], &upool[u->name]);
868 if (trans->system.packages[s - spkgs] & TRANS_PACKAGE_PRESENT)
869 razor_merger_add_package(merger, s);
871 } else if (cmp == 0) {
872 if (trans->system.packages[s - spkgs] & TRANS_PACKAGE_PRESENT)
873 razor_merger_add_package(merger, s);
874 if (trans->upstream.packages[u - upkgs] & TRANS_PACKAGE_PRESENT)
875 razor_merger_add_package(merger, u);
880 if (trans->upstream.packages[u - upkgs] & TRANS_PACKAGE_PRESENT)
881 razor_merger_add_package(merger, u);
886 razor_transaction_destroy(trans);
888 return razor_merger_finish(merger);
892 razor_transaction_destroy(struct razor_transaction *trans)
894 assert (trans != NULL);
896 transaction_set_release(&trans->system);
897 transaction_set_release(&trans->upstream);