# HG changeset patch # User Dan Winship # Date 1202320970 18000 # Node ID 1d54922ff9208fdb873bc4028c32824294b639f2 # Parent e408ff1d4a4d86895c61ae3c79ff0b3c20c72aa7 clean up some duplicated code around calls to add_to_property_pool diff -r e408ff1d4a4d -r 1d54922ff920 razor.c --- a/razor.c Wed Feb 06 12:59:27 2008 -0500 +++ b/razor.c Wed Feb 06 13:02:50 2008 -0500 @@ -336,7 +336,7 @@ p = array_add(pool, properties->size); memcpy(p, properties->data, properties->size); - p[properties->size / sizeof *p - 1] |= RAZOR_IMMEDIATE; + p[properties->size / sizeof *p - 1] |= RAZOR_ENTRY_LAST; return p - (uint32_t *) pool->data; } @@ -432,11 +432,9 @@ void razor_importer_finish_package(struct razor_importer *importer) { - struct razor_package *p; - - p = importer->package; - p->properties = add_to_property_pool(&importer->set->property_pool, - &importer->properties); + importer->package->properties = + add_to_property_pool(&importer->set->property_pool, + &importer->properties); array_release(&importer->properties); } @@ -699,13 +697,8 @@ set->properties.size = (void *) up - set->properties.data; rp_end = up; for (rp = set->properties.data, p = pkgs; rp < rp_end; rp++, p++) { - if (p->size / sizeof *r == 1) { - r = p->data; - rp->packages = *r | RAZOR_IMMEDIATE; - } else { - rp->packages = - add_to_property_pool(&set->package_pool, p); - } + rp->packages = + add_to_property_pool(&set->package_pool, p); array_release(p); } @@ -754,7 +747,7 @@ { struct import_directory *p, *end; struct razor_entry *e = NULL; - uint32_t s, *r; + uint32_t s; p = d->files.data; end = d->files.data + d->files.size; @@ -765,15 +758,8 @@ e->start = p->count > 0 ? s : 0; s += p->count; - if (p->packages.size == 0) { - e->packages = ~0; - } else if (p->packages.size / sizeof *r == 1) { - r = p->packages.data; - e->packages = *r | RAZOR_IMMEDIATE; - } else { - e->packages = add_to_property_pool(&set->package_pool, - &p->packages); - } + e->packages = add_to_property_pool(&set->package_pool, + &p->packages); array_release(&p->packages); p++; } @@ -1584,13 +1570,8 @@ prop_end = set->properties.data + set->properties.size; a = pkgs; for (prop = set->properties.data; prop < prop_end; prop++, a++) { - if (a->size / sizeof *r == 1) { - r = a->data; - prop->packages = *r | RAZOR_IMMEDIATE; - } else { - prop->packages = - add_to_property_pool(&set->property_pool, a); - } + prop->packages = + add_to_property_pool(&set->property_pool, a); array_release(a); } free(pkgs);