# HG changeset patch # User J. Ali Harlow # Date 1412442778 -3600 # Node ID 56ff755c268cf21322b7d6ec0cd4dd592a6388fa # Parent 1fd1d221092d31f013f3ae10a38550c910fb4096 Only export symbols starting with razor_ in dynamic library. Apart from being good practice to avoid clashes with higher-level libraries and the application, this also fixes an obscure bug: The gnulib library is used both by librazor (the dynamic library) and by razor (the executable). In doing so, we want to have two separate copies of the library despite the code duplication this involves. Without the explicit limit to export only razor_ symbols, the razor executable under mingw64 was picking up the getopt_long function from librazor and the optind variable from libgnu which meant that it did not see optind changing. Hiding librazor's copy of getopt causes the linker to find libgnu's copy and everything works. Note that under mingw librazor-#.dll still contains undocumented (private) razor_ symbols but these will do no harm as long as nobody tries to use them. diff -r 1fd1d221092d -r 56ff755c268c librazor/Makefile.am --- a/librazor/Makefile.am Fri Oct 03 15:05:33 2014 +0100 +++ b/librazor/Makefile.am Sat Oct 04 18:12:58 2014 +0100 @@ -47,7 +47,7 @@ librazor_la_LIBADD = $(ZLIB_LIBS) types/libtypes.la $(LUA_LIBS) \ ../gl/libgnu.la $(INTLLIBS) $(EXTRA_LIBS) -librazor_la_LDFLAGS = -no-undefined \ +librazor_la_LDFLAGS = -no-undefined -export-symbols-regex '^razor_' \ -version-info $(LT_CURRENT):$(LT_REVISION):$(LT_AGE) if HAVE_LUA