# HG changeset patch # User Kristian H?gsberg # Date 1201019668 18000 # Node ID 9d4d62f627353eebb85c7e854b5046a1ac329b3f # Parent 2ddc6448762e798452ed8e3a754e402a6272bae4 Fix comparisong bug in razor_set_diff(). We could end up calling the callback for p1 even if it's NULL, if p2 != NULL and the previous comparison left res == -1. diff -r 2ddc6448762e -r 9d4d62f62735 razor.c --- a/razor.c Tue Jan 22 00:08:13 2008 -0500 +++ b/razor.c Tue Jan 22 11:34:28 2008 -0500 @@ -1797,7 +1797,7 @@ struct razor_package_iterator *pi1, *pi2; struct razor_package *p1, *p2; const char *name1, *name2, *version1, *version2; - int res = 0; + int res; pi1 = razor_package_iterator_create(set); pi2 = razor_package_iterator_create(upstream); @@ -1810,6 +1810,8 @@ res = strcmp(name1, name2); if (res == 0) res = versioncmp(version1, version2); + } else { + res = 0; } if (p2 == NULL || res < 0)